Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element is leaf and forest is local checks [2/3] #1080

Merged
merged 16 commits into from
Jun 19, 2024
Merged

Conversation

holke
Copy link
Collaborator

@holke holke commented Jun 5, 2024

Describe your changes here:

  • Added a function t8_forest_element_is_leaf to check whether a given element is a leaf in a forest.
  • Added a function t8_forest_tree_is_local to check whether a given tree id belongs to a local tree.
  • Added a test for t8_forest_element_is_leaf

Merge after #1079

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@holke holke mentioned this pull request Jun 5, 2024
14 tasks
src/t8_forest/t8_forest_cxx.cxx Outdated Show resolved Hide resolved
src/t8_forest/t8_forest_general.h Outdated Show resolved Hide resolved
src/t8_forest/t8_forest_cxx.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_element_is_leaf.cxx Outdated Show resolved Hide resolved
@lukasdreyer lukasdreyer assigned holke and unassigned lukasdreyer Jun 10, 2024
@holke holke added enhancement Enhances already existing code Follow-up PR labels Jun 19, 2024
@holke holke assigned lukasdreyer and unassigned holke Jun 19, 2024
@holke holke enabled auto-merge June 19, 2024 08:59
@holke holke merged commit 9308dd6 into main Jun 19, 2024
10 checks passed
@holke holke deleted the feature-element_is_leaf branch June 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code Follow-up PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants