Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reproject example #491

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Update reproject example #491

merged 8 commits into from
Jan 21, 2025

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Jan 15, 2025

Also stub out howto guides section

Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments

docs/howto_guides/sample_data.rst Outdated Show resolved Hide resolved
docs/howto_guides/sample_data.rst Outdated Show resolved Hide resolved
docs/howto_guides/sample_data.rst Outdated Show resolved Hide resolved
@Cadair Cadair merged commit 041ee09 into DKISTDC:main Jan 21, 2025
22 of 25 checks passed
@Cadair Cadair deleted the fix_mosaic branch January 21, 2025 10:22
Copy link
Contributor

@eigenbrot eigenbrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was already merged, but here are my comments all the same. Sorry for the late reply.


```{code-cell} ipython3
ds = dkist.load_dataset(asdf_file)
ds = dkist.load_dataset(VBI_AJQWW / "VBI_L1_20231016T184519_AJQWW.asdf")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this works without needing to specify the metadata filename. I.e., ds = dkist.load_dataset(VBI_AJQWW) works. Do we care about that difference here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specifically to temporarily work around the issue with differently named asdfs.

Downloading the Sample Data with Globus
=======================================

The Python tools provide a few different partial datasets as sample data, these are used in documentation and examples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "...sample data, which are used..."?

=======================================

The Python tools provide a few different partial datasets as sample data, these are used in documentation and examples.
This how to guide will show you how to download the complete data for these datasets, or let you change the dataset for a different one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe capitalize "How To Guide"?

Also the last clause reads a little weird. Maybe "..., or any dataset you want." or something similar?

Searching for and downloading the ASDF file
-------------------------------------------

Using the `BKPLX <https://dkist.data.nso.edu/datasetview/BKPLX>`__ dataset from the VISP we download the ASDF file and create a `dkist.Dataset` object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking to the future that this PR is creating we should probably replace references to an "ASDF file" with something like "metadata file".

import dkist.net

results = Fido.search(a.dkist.Dataset("BKPLX"))
asdf_file = Fido.fetch(results)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf_file -> metadata_file?

Downloading the FITS files with Globus
--------------------------------------

Having loaded the ASDF file into a `dkist.Dataset` as this is a VISP dataset with polarimetry, we can download the Stokes I profile by indexing the first element of the first dimension:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This ViSP dataset has a polarimetric (Stokes) axis and so we can download only Stokes-I data by indexing to the first element of the first dimension:"

```

We can now make a composite plot of all the tiles.
We can now make a composite plot of all the tiles, at the first timestep.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lose the comma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants