Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify axis label handling for TiledDataset.plot #454

Closed
wants to merge 1 commit into from

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Oct 24, 2024

This also means that we have compatiblity with astropy/astropy#17243

Copy link

codspeed-hq bot commented Oct 24, 2024

CodSpeed Performance Report

Merging #454 will not alter performance

Comparing Cadair:better_wcsaxes_api (b92c3d4) with main (c696a85)

Summary

✅ 9 untouched benchmarks

@Cadair Cadair requested a review from SolarDrew October 24, 2024 13:48
@Cadair Cadair added the No Changelog Entry Needed This pull request does not need a changelog entry label Oct 28, 2024
@Cadair Cadair force-pushed the better_wcsaxes_api branch from e1e9ac6 to b92c3d4 Compare October 28, 2024 15:25
@Cadair
Copy link
Member Author

Cadair commented Oct 28, 2024

This requires astropy/astropy#17202 to work, so we would need to have a min astropy requirement of 6.1.5 before we can apply this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Entry Needed This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant