Add a devdeps figure build #448
Conversation
CodSpeed Performance ReportMerging #448 will not alter performanceComparing Summary
|
Cadair
added
the
No Changelog Entry Needed
| figure-!devdeps: matplotlib==3.9.1 | ||
| figure-!devdeps: mpl-animators==1.1.1 | ||
| figure-!devdeps: astropy==6.1.1 | ||
| figure-!devdeps: ndcube==2.2.2 |
There was a problem hiding this comment.
Should these packages not be pinned for figure-devdeps as well?
There was a problem hiding this comment.
We install all the git versions of them instead, so we can't have both.
There was a problem hiding this comment.
Oh yes, I see. Well then won't that (potentially) lead to figure differences as the packages change on git?
There was a problem hiding this comment.
yeah some of the differences could be something irrelevant has changed upstream, or it could be a legitimate API change. Unfortunately there's no way to test the latter without running the risk of the former. fwiw, random hash breakages don't seem to happen that much on astropy/sunpy.
|
One small question, otherwise looks fine 👍 |
We should test our figures against at least astropy main