Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bug in #439 #440

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Correct bug in #439 #440

merged 2 commits into from
Sep 26, 2024

Conversation

SolarDrew
Copy link
Contributor

Small error which slipped past me.

Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #440 will not alter performance

Comparing SolarDrew:tests (b9c494d) with main (d8c33ee)

Summary

✅ 9 untouched benchmarks

@Cadair
Copy link
Member

Cadair commented Sep 26, 2024

Should we have a tox test env where we pass in the sample data via the cli to see what happens?

@Cadair Cadair merged commit fb3ca0d into DKISTDC:main Sep 26, 2024
22 of 23 checks passed
@SolarDrew
Copy link
Contributor Author

Yeah I think that's a good idea actually. Wonder if that could be hooked into something to automate a list of known failures 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants