Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing datasets to tests via command line #439

Merged
merged 17 commits into from
Sep 26, 2024
Merged

Conversation

SolarDrew
Copy link
Contributor

Adds a pytest cli option --ds which accepts a comma-separated list of strings that can be parsed by load_dataset(). If present, these are passed to any test with the accept_cli_datasets marker in place of the fixture dataset(s) actually specified for that test in the code.

The aim here is to be able to run arbitrary datasets through the test suite to more easily find issues with new data.

Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #439 will not alter performance

Comparing SolarDrew:tests (f277cea) with main (a34aaf4)

Summary

✅ 9 untouched benchmarks

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat, and will be useful. Needs documenting somewhere, though god knows where.

dkist/dataset/tests/test_dataset.py Outdated Show resolved Hide resolved
dkist/dataset/tests/test_tiled_dataset.py Show resolved Hide resolved
dkist/conftest.py Outdated Show resolved Hide resolved
changelog/439.feature.rst Outdated Show resolved Hide resolved
dkist/dataset/tests/test_dataset.py Outdated Show resolved Hide resolved
dkist/dataset/tests/test_dataset.py Show resolved Hide resolved
docs/developer.rst Show resolved Hide resolved
@Cadair Cadair merged commit d8c33ee into DKISTDC:main Sep 26, 2024
19 of 21 checks passed
@Cadair
Copy link
Member

Cadair commented Sep 26, 2024

Thanks Drew

Cadair pushed a commit that referenced this pull request Sep 26, 2024
* Big ol' bug

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants