Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileManager to TiledDataset #437

Merged
merged 10 commits into from
Sep 30, 2024
Merged

Conversation

SolarDrew
Copy link
Contributor

Does what it says on the tin. Addresses but doesn't necessarily close #244

Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #437 will improve performances by 10.4%

Comparing SolarDrew:tiledds-improvements (795c4b6) with main (fb3ca0d)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark main SolarDrew:tiledds-improvements Change
test_generate_celestial 5.8 ms 5.3 ms +10.4%

@SolarDrew
Copy link
Contributor Author

Well I'm slightly confused and concerned by the 10% speed improvement to test_generate_celestial() because I didn't think I'd changed anything that would affect it...

@Cadair Cadair force-pushed the tiledds-improvements branch from 2fb2bea to 41c9f42 Compare September 19, 2024 11:46
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (fb3ca0d) to head (795c4b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   96.69%   96.71%   +0.02%     
==========================================
  Files          68       68              
  Lines        4321     4352      +31     
==========================================
+ Hits         4178     4209      +31     
  Misses        143      143              
Flag Coverage Δ
42.89% <21.87%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SolarDrew SolarDrew merged commit 6770e8e into DKISTDC:main Sep 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiledDataset needs more helpers for working over all tiles
2 participants