-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset.__repr__
upgrade
#431
Conversation
CodSpeed Performance ReportMerging #431 will not alter performanceComparing Summary
|
Update:
|
what it actually shows
b52ff97
to
9b4ac7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think we should add some tests. I don't want to get too prescriptive with the tests, but checking that things like the instrument name, dataset id, etc are in the generated repr would be good.
I would just skip the test in 1.0rst we don't need to pull up old release notes to current standard. https://github.com/DKISTDC/dkist/actions/runs/10665166513/job/29557982384?pr=431#step:10:982 |
Any last objections before we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some updates to make the dataset representation a bit more user friendly and informative. Includes changes to
TiledDataset.__repr__
from #402 so that should probably be merged first.Output for the sample VISP and VBI datasets: