Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting helpers for TiledDataset #408

Merged
merged 31 commits into from
Aug 7, 2024

Conversation

SolarDrew
Copy link
Contributor

Adds a TiledDataset.plot() method which creates a quick-look plot as per the example here.

At the moment only plots the first image in each tile. Unsure whether to try and construct an animation like the normal dataset plotting or to pass an index argument to the plot to determine which slice is shown.

Closes #405

Copy link

codspeed-hq bot commented Jun 27, 2024

CodSpeed Performance Report

Merging #408 will not alter performance

Comparing SolarDrew:tiledds-improvements-plot (76b9a93) with main (9bcf699)

Summary

✅ 7 untouched benchmarks

@Cadair Cadair force-pushed the tiledds-improvements-plot branch from 6dcdb12 to cf497c1 Compare July 18, 2024 12:48
@Cadair
Copy link
Member

Cadair commented Jul 23, 2024

@SolarDrew can you rebase this horror show?

@SolarDrew SolarDrew force-pushed the tiledds-improvements-plot branch from 8753c6f to a1cf462 Compare July 24, 2024 14:32
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like codecov isn't uploading from the figure tests?

dkist/dataset/tests/test_tiled_dataset.py Outdated Show resolved Hide resolved
dkist/dataset/tests/test_tiled_dataset.py Outdated Show resolved Hide resolved
@SolarDrew
Copy link
Contributor Author

I think this is good to go unless there are any more issues you can see with it.

@SolarDrew SolarDrew merged commit b56cc10 into DKISTDC:main Aug 7, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants