Tests for Dataset.crop() #310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 97.03% 97.68% +0.65%
==========================================
Files 65 32 -33
Lines 4009 1855 -2154
==========================================
- Hits 3890 1812 -2078
+ Misses 119 43 -76 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #310 will not alter performanceComparing Summary
|
|
This has suspiciously worked? |
Co-authored-by: Stuart Mumford <[email protected]>
|
I think this is now just waiting on an actual release of gwcs, assuming the next one is 0.22.2 and includes spacetelescope/gwcs#457 . At that point the devdeps build should pass without any further changes here and everything will be wonderful and lovely. |
|
Oh wait that build is passing and it shouldn't be. Never mind. |
| import astropy.units as u | ||
| from astropy.coordinates import SkyCoord, SpectralCoord, StokesCoord | ||
| from astropy.time import Time | ||
|
|
||
| gwcs = pytest.importorskip("gwcs", "0.22.2") |
There was a problem hiding this comment.
I was thinking more in the test which needed this, but if they all do this is fine.
Adds test for various different use-cases of crop with a couple of datasets from different instruments. Depends on spacetelescope/gwcs#457 for a number of gWCS fixes.