convert varying_celestial_tranform schema ref to uri instead of tag #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 40 40
Lines 2451 2451
=======================================
Hits 2409 2409
Misses 42 42 ☔ View full report in Codecov by Sentry. |
Cadair
reviewed
Oct 12, 2023
CHANGELOG.rst
Outdated
| @@ -14,6 +14,7 @@ Bug Fixes | |||
| - Fix minor bugs for header slicing functionality and expand test coverage for edge-cases. (`#275 <https://github.com/DKISTDC/dkist/pull/275>`_) | |||
| - Fixed inverse transform in `.VaryingCelestialTransformSlit2D`. Which fixes a bug in VISP WCSes. (`#285 <https://github.com/DKISTDC/dkist/pull/285>`_) | |||
| - Fix a bug preventing the transfer of a single dataset with :meth:`~dkist.net.transfer_complete_datasets`. (`#288 <https://github.com/DKISTDC/dkist/pull/288>`_) | |||
| - Update varying celestial transform schema ref to use a uri instead of a tag.(`#298 <https://github.com/DKISTDC/dkist/pull/298>`_) | |||
There was a problem hiding this comment.
Same here as #297 could you add this to the changelog/ directory please?
There was a problem hiding this comment.
Thanks! I added 298.bugfix.rst. Should this be a 'bugfix' or something else?
Cadair
reviewed
Oct 12, 2023
| @@ -30,7 +30,7 @@ properties: | |||
| - tag: "core/ndarray-1.0.0" | |||
| - tag: "tag:stsci.edu:asdf/unit/quantity-1.1.0" | |||
| projection: | |||
| $ref: "tag:stsci.edu:asdf/transform/transform-1.2.0" | |||
| $ref: "http://stsci.edu/schemas/asdf/transform/transform-1.2.0" | |||
There was a problem hiding this comment.
Can this be / should this be asdf://?
There was a problem hiding this comment.
Closed
Cadair
approved these changes
Oct 13, 2023
Cadair
pushed a commit
to Cadair/dkist
that referenced
this pull request
Oct 16, 2023
…KISTDC#298) * convert varying_celestial_tranform schema ref to uri instead of tag * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asdf 3.0 will begin issuing a warning when a non-uri tag is encountered in a schema
$ref. One such tag exists in the varying celestial transform schema:https://github.com/DKISTDC/dkist/blob/main/dkist/io/asdf/resources/schemas/varying_celestial_transform-1.0.0.yaml#L33
This PR updates the schema replacing the tag with the corresponding and equivalent uri (
http://stsci.edu/schemas/asdf/transform/transform-1.2.0). The uri used to replace the tag is identical to the uri that is resolved by the tag and should have no impact on the schema or code that uses the schema (aside from preventing the warning when asdf 3.0 is released).