-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect block index sections from asdf test data #296
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 40 40
Lines 2452 2452
=======================================
Hits 2410 2410
Misses 42 42 ☔ View full report in Codecov by Sentry. |
edfce63
to
9c23b5e
Compare
9c23b5e
to
8421116
Compare
I wasn't sure if these changes warranted a changelog. I'm unable to change labels (if there is one that allows |
Co-authored-by: Stuart Mumford <[email protected]>
I don't know if it's related to this PR yet or not, but I just tried to write a test which makes use of the WCSes in these files and it's now causing segfaults, which is fun. @braingram got any ideas? 😆 |
Without this PR the 1.0.0 eit_dataset file does not segfault the others do. with this PR 1.0.0 does as well but not 1.1.0 (which wasn't modified in this PR). |
Would you point me to the test? Using asdf main and dkist main and af = asdf.open('dkist/data/test/eit_dataset-1.0.0.asdf')
w = af['dataset'].wcs
af.close()
print(w) # segfault Keeping the file open (which by default is being memory mapped) prevents the segfault. Also, passing |
…ISTDC#296)" This reverts commit 1529024.
Asdf is making some major updates to internal block reading and writing code (see this PR for the extensive changes).
One of the changes includes issuing a new warning when a file is opened which contains an incorrect block index. The block index is a small, optional YAML document at the end of an ASDF file that contains the offsets of each ASDF binary block within the ASDF file (see the asdf-standard docs for more details). Hand editing ASDF files can often lead to incorrect offsets in the block index. When asdf detects a block index that is incorrect (or if no block index is found) it ignores the block index and falls back to reading blocks sequentially starting with the first.
With dkist main tested against the above asdf PR several tests are failing (see here for the full log):
This is due to several test files in the dkist repository that contain block index offsets that are incorrect (see the changed files in this PR).
This PR deletes the invalid block index from each of these files.