Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: patch job metadata endpoint #397

Merged
merged 5 commits into from
Mar 7, 2025
Merged

feat: patch job metadata endpoint #397

merged 5 commits into from
Mar 7, 2025

Conversation

ryuwd
Copy link
Contributor

@ryuwd ryuwd commented Feb 5, 2025 •
edited
Loading

Todo:

  • Write PATCH /metadata
  • Tests
    • test patching attributes and parameters
    • test getting job status history in /search

Closes #162

@ryuwd ryuwd force-pushed the roneil-jobstateupdatehandler branch 2 times, most recently from 052332b to d2106a3 Compare February 7, 2025 14:08
@ryuwd ryuwd changed the title metadata patch endpoint feat: patch job metadata endpoint Feb 7, 2025
@ryuwd ryuwd force-pushed the roneil-jobstateupdatehandler branch 3 times, most recently from 328cf93 to 46559f7 Compare February 10, 2025 17:38
@ryuwd ryuwd mentioned this pull request Feb 11, 2025
Open
@ryuwd ryuwd force-pushed the roneil-jobstateupdatehandler branch 2 times, most recently from 46559f7 to dc8bee3 Compare February 20, 2025 17:28
@ryuwd ryuwd marked this pull request as ready for review February 20, 2025 17:57
@ryuwd
Copy link
Contributor Author

ryuwd commented Feb 20, 2025

Rebased and ready to go

@aldbr aldbr force-pushed the roneil-jobstateupdatehandler branch 2 times, most recently from a29bf3e to 41cbccf Compare March 6, 2025 12:30
@ryuwd
Copy link
Contributor Author

ryuwd commented Mar 6, 2025

@aldbr LGTM, please go ahead

@aldbr aldbr force-pushed the roneil-jobstateupdatehandler branch from 06ec05d to ede0868 Compare March 6, 2025 13:16
ryuwd added 4 commits March 7, 2025 13:03
@ryuwd
start writing metadata patch endpoint
2035987 
add policy

Missing awaits and return results

adjust returned output

Fixed mypy

mypy false positive?

and line 34
@ryuwd
set_job_parameters_or_attributes --> patch_metadata
53ce516 
Return 204 no content

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
@ryuwd
Added first test and fixed some parts of patch_metadata
090429c 
Remove breakpoint

pre-commit

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
@ryuwd
Check for user mistakes
250fc78 
Adjustments/fixes
@ryuwd ryuwd force-pushed the roneil-jobstateupdatehandler branch from a761378 to 250fc78 Compare March 7, 2025 12:04
@ryuwd
Copy link
Contributor Author

ryuwd commented Mar 7, 2025

I think this is good to go now. Thanks for the help @aldbr @fstagni !

@fstagni fstagni merged commit a2e3fb0 into DIRACGrid:main Mar 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaen chaen chaen left review comments

@chrisburr chrisburr chrisburr left review comments

@fstagni fstagni fstagni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add routes for JobStateUpdateHandler
4 participants
@ryuwd @fstagni @chaen @chrisburr