Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metalnx fixes 1 #497

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Metalnx fixes 1 #497

merged 4 commits into from
Feb 11, 2025

Conversation

JustinKyleJames
Copy link
Collaborator

These are updates needed for Metalnx.

@alanking alanking mentioned this pull request Feb 4, 2025
Merged
@alanking alanking changed the title Metanx fixes 1 Metalnx fixes 1 Feb 4, 2025
alanking
alanking reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some potentially naive questions / observations, and some nitpicks.

korydraughn
korydraughn reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

alanking
alanking reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good. I don't have anything to add here

korydraughn
korydraughn reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're very close.

Once we review the other permission enum edits, we should be ready for a run of the Jargon test suite.

@korydraughn korydraughn mentioned this pull request Feb 11, 2025
Merged
@JustinKyleJames
Copy link
Collaborator Author

Jargon tests passed. The only changes I had to make were READ_OBJECT -> READ and MODIFY_OBJECT -> WRITE changes in tests which were essentially reverting them back to what they were before.

I also squashed.

@korydraughn
Copy link
Collaborator

Is this ready?

alanking
alanking approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alanking
Copy link
Collaborator

Probably should wait for @korydraughn's approval before #'ing.

korydraughn
korydraughn approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Looks good.

Pound it.

@JustinKyleJames
Copy link
Collaborator Author

I agree. Looks good.

Pound it.

done

@korydraughn korydraughn merged commit 4cf8654 into DICE-UNC:master Feb 11, 2025
1 of 2 checks passed
@JustinKyleJames JustinKyleJames deleted the metanx_fixes_1 branch February 11, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn approved these changes

@alanking alanking alanking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinKyleJames @korydraughn @alanking