Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interoperability fixes (Mac OS) #52

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Interoperability fixes (Mac OS) #52

merged 2 commits into from
Sep 13, 2024

Conversation

chrisvanrun
Copy link
Collaborator

We don't fully support Mac OS env but I've seen a few challenge admins stub their toe against these. A small effort to fix these.

The date and id binary interfaces seem different for a Mac OS environment. The binary sed is, I hope, more universal. Quick test on an in-house Mac OS suggests this works.

@pkcakeout
Copy link
Member

Randomly saw this popping up in the notification feed. Only wanted to check the pitch I am assigned to, but well:

https://unix.stackexchange.com/questions/550305/date-command-on-mac-bash

There i a package on MacOs that you install to get the GNU-Coreutils. You need to use full paths in that case. But it might generally be easier for us to require that people install GNU coreutils and then use those? Would be my suggestion. Ties together the different evnironments.

@chrisvanrun
Copy link
Collaborator Author

Randomly saw this popping up in the notification feed. Only wanted to check the pitch I am assigned to, but well:

https://unix.stackexchange.com/questions/550305/date-command-on-mac-bash

There i a package on MacOs that you install to get the GNU-Coreutils. You need to use full paths in that case. But it might generally be easier for us to require that people install GNU coreutils and then use those? Would be my suggestion. Ties together the different evnironments.

Generally, YES! We don't support Mac OS. But this is just a tiny change, not making it would seem pedantic.

Copy link
Contributor

@amickan amickan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisvanrun chrisvanrun merged commit 073d709 into main Sep 13, 2024
8 checks passed
@chrisvanrun chrisvanrun deleted the mac-os-proof branch September 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants