Remove signal listener as it made the executor unstable

grand_challenge_forge/partials/example-evaluation-method/example-evaluation-method{{cookiecutter._}}/helpers.py

@@ -100,35 +100,21 @@ def _start_pool_worker(fn, predictions, max_workers, results, errors):
 
 def _pool_worker(*, fn, predictions, max_workers, results, errors):
     terminating_child_processes = False
-    executor_shutting_down = False
+
     with ProcessPoolExecutor(max_workers=max_workers) as executor:
         try:
 
-            def handle_error(error, prediction="Unknown"):
+            def handle_error(error, prediction):
                 nonlocal terminating_child_processes
                 if terminating_child_processes:
                     return
 
-                nonlocal executor_shutting_down
-                if not executor_shutting_down:
-                    executor_shutting_down = True
-                    executor.shutdown(wait=False, cancel_futures=True)
+                executor.shutdown(wait=False, cancel_futures=True)
                 errors.append((prediction, error))
 
                 terminating_child_processes = True
                 _terminate_child_processes()
 
-            def sigchld_handler(*_, **__):
-                if not terminating_child_processes:
-                    handle_error(
-                        RuntimeError(
-                            "Child process was terminated unexpectedly"
-                        )
-                    )
-
-            # Register the SIGCHLD handler
-            signal.signal(signal.SIGCHLD, sigchld_handler)
-
             # Submit the processing tasks of the predictions
             futures = [
                 executor.submit(fn, prediction) for prediction in predictions

tests/test_evaluate_helpers.py

@@ -27,7 +27,7 @@
 
 # Some of the test below, if things go wrong, can potentially deadlock.
 # So we set a maximum runtime
-pytestmark = pytest.mark.timeout(5)
+pytestmark = pytest.mark.timeout(4)
 
 
 def working_process(p):
@@ -55,26 +55,18 @@ def forever_process(*_):
         time.sleep(1)
 
 
-def send_signals_to_process(process, signal_to_send, interval):
-    while True:
-        try:
-            os.kill(process.pid, signal_to_send)
-        except ProcessLookupError:
-            # Race conditions sometimes have this try and send a signal even though
-            # the process is already terminated
-            pass
-        time.sleep(interval)
-
-
 def stop_children(process, interval):
-    while True:
+    stopped = False
+    while not stopped:
         process = psutil.Process(process.pid)
         children = process.children(recursive=True)
-        for child in children:
-            try:
-                child.kill()
-            except psutil.NoSuchProcess:
-                pass  # Not a problem
+        if children:
+            for child in children:
+                try:
+                    child.kill()
+                except psutil.NoSuchProcess:
+                    pass  # Not a problem
+            stopped = True
         time.sleep(interval)
 
 
@@ -135,6 +127,6 @@ def add_child_terminator(*args, **kwargs):
         if child_stopper:
             child_stopper.terminate()
 
-    assert "Child process was terminated unexpectedly" in str(
+    assert "A process in the process pool was terminated abruptly" in str(
         excinfo.value.error
     )