Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/review and update template #2

Merged
merged 22 commits into from
Oct 2, 2024

Conversation

ryan-kipawa
Copy link
Contributor

No description provided.

@ryan-kipawa ryan-kipawa marked this pull request as ready for review October 1, 2024 13:11
@ryan-kipawa
Copy link
Contributor Author

ryan-kipawa commented Oct 1, 2024

Should we include a manual action for publishing to TestPyPI, similar to this:

https://github.com/pypa/packaging.python.org/blob/main/source/guides/github-actions-ci-cd-sample/publish-to-test-pypi.yml

Could be a useful sanity check for new package maintainers

Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - did you test if it works by using the template?

@ryan-kipawa
Copy link
Contributor Author

Not yet, but I'll do that 😄

@jsmariegaard
Copy link
Member

Not yet, but I'll do that 😄

I could also have done that as review - but I am too busy right now. Sorry 🫣

@ryan-kipawa
Copy link
Contributor Author

No worries, it was a good process for me to go through anyways. Confirmed that it's all working now 🚀

@ryan-kipawa ryan-kipawa merged commit 1e7f1d2 into main Oct 2, 2024
4 checks passed
@jsmariegaard jsmariegaard deleted the maintenance/review_and_update_template branch October 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants