Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input file components #351

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add input file components #351

wants to merge 3 commits into from

Conversation

DenizYil
Copy link
Collaborator

@DenizYil DenizYil commented Jun 7, 2023

This PR

Adds the InputFile component, which supports a dropzone, a button and an icon button. It has a variety of features, such as:

  • you can specify replaceOnUpload which decides if the uploaded files should be replaced or extended if you upload again
  • you can specify showFiles if files should be shown or not. for dropzone, if this is enabled (which it is by default), the user will have the ability to remove items as well.
  • quantity: one or multiple files?
  • ... and more

Notes

  • No notes to add

Fulfilled the scope of this repo?

  • The same functionality of the component can not be achieved with theming, basic styling or composition of existing components
  • The component implements an element of the DHI Design Guidelines or is otherwise generic enough in functionality and close enough to the DHI CVI that it is likely to find reuse in other projects

Completness

  • Story included

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-glacier-08aae7903-351.westeurope.azurestaticapps.net

@DenizYil
Copy link
Collaborator Author

Feedback from Razvan:

  • Use chips instead
  • Add a buttonProps or something that specifies the styling
  • Rename prop to getFiles or something

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-glacier-08aae7903-351.westeurope.azurestaticapps.net

@DenizYil DenizYil marked this pull request as draft June 13, 2023 07:25
@DenizYil DenizYil marked this pull request as ready for review June 13, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant