Maintenance/fix warnings #98
Conversation
|
FYI Python 3.8 is not supported by latest version of pandas https://pypi.org/project/pandas/#files |
| @@ -345,10 +345,10 @@ def test_max_aggregation(self, res1d_river_network, column_mode): | |||
| df_agg = df_agg.groupby("name").agg("max") # test for entire reach (not segments) | |||
|
|
|||
| assert list(df_agg.columns.values) == [ | |||
| "max_WaterLevel", | |||
There was a problem hiding this comment.
What is the reason to shuffle this around?
There was a problem hiding this comment.
The new stack algorithm used in future pandas has a different order than before unfortunately
Should we remove Python 3.8 support? It is reaching end-of-life in 2024 Q4, |
I think so, yes. |
|
I saw that the output of some notebooks is ditched. I personally like it to be there when statically viewing it online. I suggest to revert this change. |
Yes I agree with this. My thinking was mainly to avoid messy merge conflicts with upcoming branches |
A bit of maintenance with new versions of GeoPandas and Pandas being released