-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/improve geopandas integration #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-kipawa
force-pushed
the
feature/improve_geopandas_integration
branch
from
January 30, 2024 15:05
55ccb24
to
0641861
Compare
gedaskir
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly questions in places were it was more difficult to read/understand :-).
gedaskir
approved these changes
Feb 7, 2024
ryan-kipawa
added a commit
that referenced
this pull request
Oct 11, 2024
Feature/improve geopandas integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can read results to a DataFrame, and read geometries without results to a GeoDataFrame. Currently, the user is responsible for combining these. This PR aims to facilitate that integration. Here is an example of how you can generate a GeoDataFrame containing the max of all available quantities:
An internal class called ResultFrameAggregator is introduced to handle the aggregation logic.