Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve repr and autcomplete #76

Merged
merged 9 commits into from
Jan 23, 2024
Merged

Feature/improve repr and autcomplete #76

merged 9 commits into from
Jan 23, 2024

Conversation

ryan-kipawa
Copy link
Collaborator

@ryan-kipawa ryan-kipawa commented Jan 22, 2024 •
edited
Loading

A small PR that includes:

  • Some improvements to repr (list counts, and new repr for ResultLocations, ResultQuantity, and ResultQuantityCollections)
  • Add some type hints to improve autocomplete
  • Clean repr of Res1D and moves into info() method
  • Alias res1d.result_network to res1d.network
  • Mark core tests as slow and don't run by default (but run on CI)

@ryan-kipawa ryan-kipawa force-pushed the feature/improve-repr-and-autcomplete branch from ebdf0f9 to 9f3bbe5 Compare January 22, 2024 11:26
@ryan-kipawa ryan-kipawa marked this pull request as ready for review January 22, 2024 11:28
gedaskir
gedaskir approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@gedaskir gedaskir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ryan-kipawa ryan-kipawa merged commit d4686ba into main Jan 23, 2024
4 checks passed
ryan-kipawa added a commit that referenced this pull request Oct 11, 2024
@ryan-kipawa
Merge pull request #76 from DHI/feature/improve-repr-and-autcomplete
78da790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gedaskir gedaskir gedaskir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-kipawa @gedaskir