Update _FM_utils.py #744
Merged
Update _FM_utils.py #744
+33
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the part that elements connected to each node are defined using csr_matrix function from scipy.sparse. This method works much faster than the previous one.
ecomodeller
reviewed
Nov 6, 2024
ruff extension in VS Code is used to format the code
mohm-dhi
approved these changes
Nov 19, 2024
|
It is basically doing the same thing but in a more efficient way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the initial part of the function _get_node_centered_data in _FM_utils.py that finds the elements connected to each node using csr_matrix function from scipy.sparse. This method works much faster than the previous one. The connectivity matrix is generated using _create_node_element_matrix function.