Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preprocessor fix stbImage MSVC link error #459

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Jan 31, 2024

PR Description

Remove STBimage preprocessor instruction used to fix MVSC that is no more usefull since DGtal PR 175

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Github Actions C.I. will fail).
  • All continuous integration tests pass (Github Actions).

@kerautret kerautret changed the title [TEST] test remove fix stb link error Remove preprocessor fix stbImage MSVC link error Feb 1, 2024
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! thx

@dcoeurjo dcoeurjo merged commit 6fca316 into DGtal-team:master Feb 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants