Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vol file visualization (hex mesh, point cloud, isosurface) using polyscope #455

Merged
merged 15 commits into from
Jan 27, 2024

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Dec 22, 2023

PR Description

  • Adding polysocpe to DGTalTools
  • New volscope tool

screenshot_000000
bscreenshot_000001
bscreenshot_000000

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Github Actions C.I. will fail).
  • All continuous integration tests pass (Github Actions).

@kerautret
Copy link
Member

Nice I I look it ! Btw I also made another tools on contrib here if you have time to have a look

Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tools, just some suggests and adding a new entry in the readme ? (with screen shot is could be nice)

visualisation/CMakeLists.txt Outdated Show resolved Hide resolved
visualisation/CMakeLists.txt Outdated Show resolved Hide resolved
visualisation/volscope.cpp Outdated Show resolved Hide resolved
visualisation/volscope.cpp Outdated Show resolved Hide resolved
visualisation/volscope.cpp Show resolved Hide resolved
@kerautret
Copy link
Member

ping @dcoeurjo, all almost fine from suggested commits, and it could merits also a new entry in the readme eventually with the screenshot ;)

dcoeurjo and others added 8 commits January 27, 2024 10:37
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
@kerautret kerautret merged commit da4a15d into master Jan 27, 2024
4 checks passed
@kerautret
Copy link
Member

Thanks merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants