Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp17 and Windows GitHub Action #449

Merged
merged 37 commits into from
Oct 22, 2023
Merged

Cpp17 and Windows GitHub Action #449

merged 37 commits into from
Oct 22, 2023

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Feb 16, 2023

PR Description

As done for DGtal, it also integrate GitAction configuration for windows architecture and removes appveyor check.

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Github Actions & appveyor).

@kerautret kerautret changed the title Cpp17 Cpp17 and Windows GitHub Action Oct 12, 2023
@kerautret
Copy link
Member Author

@dcoeurjo looks ready for review now ;) By the way could you remove the appveyor trigger on the settings ?

@kerautret
Copy link
Member Author

ping @dcoeurjo if you have time to remove appveyor in the setting ;)

@dcoeurjo
Copy link
Member

I think I've removed appveyor...

@dcoeurjo
Copy link
Member

Seems to still be there... maybe just remove the appveryor.yaml

@kerautret
Copy link
Member Author

I think I've removed appveyor...

thanks,

Seems to still be there... maybe just remove the appveryor.yaml

yes but it is well removed in the PR, perhaps I have to make a new commit (but needs conan fix of DGTal PR)

@kerautret
Copy link
Member Author

Thanks @dcoeurjo looks fine now ;)

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thx

@dcoeurjo dcoeurjo merged commit 6164110 into DGtal-team:master Oct 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants