-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cpp17 and Windows GitHub Action #449
Conversation
e9c1244
to
fd09c31
Compare
@dcoeurjo looks ready for review now ;) By the way could you remove the appveyor trigger on the settings ? |
ping @dcoeurjo if you have time to remove appveyor in the setting ;) |
I think I've removed appveyor... |
Seems to still be there... maybe just remove the appveryor.yaml |
thanks,
yes but it is well removed in the PR, perhaps I have to make a new commit (but needs conan fix of DGTal PR) |
2fa886a
to
bb78898
Compare
Thanks @dcoeurjo looks fine now ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thx
PR Description
As done for DGtal, it also integrate GitAction configuration for windows architecture and removes appveyor check.
Checklist
cmake
mode (otherwise, Travis C.I. will fail).