Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove redundant checks for opentiles #768

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

plule
Copy link
Contributor

@plule plule commented Jul 10, 2023

Follow-up to DFHack/df-structures#612
First half for fixing DFHack/dfhack#3526

Since the semantic change in the structure PR, "walkable" is equivalent to "able to stand on". Many tools had this check written as "not an open tile", which is now redundant with the "walkable" attribute. Remove the redundant checks.

Note: I've only tested deep-embark with these changes, but I think it's quite safe

@myk002 myk002 merged commit ce97af1 into DFHack:master Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants