Merge pull request #1314 from myk002/myk_cp

[control-panel] convert numeric strings to numbers for numeric preferences
DFHack · Oct 2, 2024 · dd9592c · dd9592c
2 parents 0f84c3a + 1c2b1a0
commit dd9592c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/changelog.txt b/changelog.txt
@@ -32,6 +32,7 @@ Template for new versions:
 
 ## Fixes
 - `gui/quickfort`: only print a help blueprint's text once even if the repeat setting is enabled
+- `control-panel`: fix setting numeric preferences from the commandline
 
 ## Misc Improvements
 - `control-panel`: Add realistic-melting tweak to control-panel registry

diff --git a/internal/control-panel/common.lua b/internal/control-panel/common.lua
@@ -180,6 +180,9 @@ function set_preference(data, in_value)
     if expected_type == 'boolean' and type(value) ~= 'boolean' then
         value = argparse.boolean(value)
     end
+    if expected_type == "number" then
+        value = tonumber(value) or value
+    end
     local actual_type = type(value)
     if actual_type ~= expected_type then
         qerror(('"%s" has an unexpected value type: got: %s; expected: %s'):format(