GitHub standards improvements #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app https://technical-guidance-200.test.teacherservices.cloud was deleted |
|
Changes can be found here: https://technical-guidance-200.test.teacherservices.cloud/standards/storing-source-code/#storing-source-code |
peteryates
reviewed
Aug 9, 2024
Comment on lines
131
to
133
| Repositories must: | ||
|
|
||
| - have branch protection turned on for the default branch in your repository either via traditional branch protection or via repository rules. Branch protection should include: |
There was a problem hiding this comment.
I agree with this for high stakes repos (i.e., those tied to transactional services, etc) but we have loads where this is a bit overkill. I don't think this should be a hard requirement for things like prototypes and design histories.
There was a problem hiding this comment.
Changed to be explicit about which repos
peteryates
reviewed
Aug 9, 2024
peteryates
reviewed
Aug 9, 2024
|
Looks great, left a few really minor comments. |
…rvice standards, and industry best practice
pritchyspritch
force-pushed
the
github-standards-improvements
branch
from
51232d6
to
bc089ef
Compare
peteryates
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the PR #165 with additional guidance/standards.
Changes include repo requirements that :