Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7650] Figure out flaky #4719

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[7650] Figure out flaky #4719

wants to merge 13 commits into from

Conversation

defong
Copy link
Contributor

@defong defong commented Oct 15, 2024

Context

Changes proposed in this pull request

Guidance to review

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@defong defong force-pushed the 7650-figure-out-flaky branch 2 times, most recently from 15ad26c to cdc7f15 Compare October 17, 2024 08:49
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (0f08600) to head (0b0b32d).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4719      +/-   ##
==========================================
+ Coverage   86.11%   94.65%   +8.54%     
==========================================
  Files         725      731       +6     
  Lines       15724    15872     +148     
==========================================
+ Hits        13541    15024    +1483     
+ Misses       2183      848    -1335     
Flag Coverage Δ
unittests 94.65% <ø> (+8.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant