Add parity check UI #1829
Open
Add parity check UI #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-1829-web.test.teacherservices.cloud/ |
ethax-ross
force-pushed
the
3616-add-parity-check-ui
branch
from
2ec7a23
to
5a581d6
Compare
ethax-ross
force-pushed
the
3616-add-parity-check-ui
branch
from
5a581d6
to
ff59050
Compare
Add a basic UI to kick off a parity check and view the progress/completion status. Add `ParityCheckJob` to run parity checks in the background. Add methods to `ParityCheck` service for tracking progress. Add `ParityChecksController` and associated views; no details of the check results are surfaced yet, just the functionality to start and view the overall status. DRY up parity check tests with `migration_helper`.
ethax-ross
force-pushed
the
3616-add-parity-check-ui
branch
from
ff59050
to
7ca687e
Compare
ethax-ross
force-pushed
the
3616-add-parity-check-ui
branch
from
7ca687e
to
8f2b8b6
Compare
Fleshes out the bare-bones parity check UI with an overview list of the paths called for each provider on the completion page. If the request responses/status codes are different you can click on the path to view a detailed report of the comparison along with a diff of the response bodies. Also includes a basic response time comparison chart that plots the averages and min/max for each path. Add detailed repsonse comparison action/view. Add `diffy` to compare response bodies. Update CSRP to allow chart.js from a CDN (as its only used on this page and it will be deleted shortly I figured this was the best way to include it/ensure its removed). Remove `equal?` from `ResponseComparison` as this is a system method it started giving issues; we can just negate `different?` in its place.
ethax-ross
force-pushed
the
3616-add-parity-check-ui
branch
from
8f2b8b6
to
f1d65d0
Compare
|
|
just had a walkthrough and this is absolutely brilliant thank you @ethax-ross 👏! Will review in a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to be able to kick off a parity check from the UI (similar to migrations) and view the progress/results.
Changes proposed in this pull request
Add a basic UI to kick off a parity check and view the progress/completion status.
Add
ParityCheckJobto run parity checks in the background.Add methods to
ParityCheckservice for tracking progress.Add
ParityChecksControllerand associated views; no details of the check results are surfaced yet, just the functionality to start and view the overall status.DRY up parity check tests with
migration_helper.Fleshes out the bare-bones parity check UI with an overview list of the paths called for each provider on the completion page. If the request responses/status codes are different you can click on the path to view a detailed report of the comparison along with a diff of the response bodies. Also includes a basic response time comparison chart that plots the averages and min/max for each path.
Add detailed response comparison action/view.
Add
diffyto compare response bodies.Update CSRP to allow chart.js from a CDN (as its only used on this page and it will be deleted shortly I figured this was the best way to include it/ensure its removed).
Remove
equal?fromResponseComparisonas this is a system method it started giving issues; we can just negatedifferent?in its place.Guidance for review
This has been tested on migration; the screenshots below are fabricated to show the diffing though. In migration it flags expected differences on statements (date and the missing
typeattribute from NPQ).