Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility changes #1807

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Accessibility changes #1807

wants to merge 7 commits into from

Conversation

EmmaFrith
Copy link
Contributor

@EmmaFrith EmmaFrith commented Oct 14, 2024

Fix 4 out of 5 accessibility issues. I will address issue no. 4 as a separate ticket/PR. Also fix n+1 queries.

Before After
Screenshot 2024-10-16 at 11 07 51 Screenshot 2024-10-16 at 11 08 25
Screenshot 2024-10-16 at 11 09 05 Screenshot 2024-10-16 at 11 09 58
Screenshot 2024-10-16 at 12 53 50 Screenshot 2024-10-16 at 12 52 51
Screenshot 2024-10-16 at 12 55 55 Screenshot 2024-10-16 at 14 43 16
Screenshot 2024-10-16 at 15 11 32 Screenshot 2024-10-16 at 15 12 06

@EmmaFrith EmmaFrith requested a review from a team as a code owner October 14, 2024 17:18
@EmmaFrith EmmaFrith marked this pull request as draft October 14, 2024 17:19
Copy link

Copy link

sonarcloud bot commented Oct 16, 2024

@EmmaFrith EmmaFrith marked this pull request as ready for review October 16, 2024 14:20
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants