Bulk edit file creation #920
Open
+222
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichikaD
requested review from
zhodges-nimble,
jack-nimbleapproach and
sukhybhullar-nimble
RichikaD
force-pushed
the
test/bulk-edit-file-creation
branch
from
44e0b01 to
5959f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work is mostly done by Sukhy. I have fixed the tests from failing ( it was failing for 2 errors - Web Compilation and there are 2 test id's with the same name 'upload' on the bulk-edit-file-upload page ) .
I have also added one more validation to check the user gets an error message when doesn't select a file
UPDATE: Added happy path and some validation scenarios. Used hardcoded data in csv apart from ProjectID