Fix heading overlap #4261
Open
Fix heading overlap #4261
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://get-into-teaching-app-review-4261.test.teacherservices.cloud |
|
gemmadallmandfe
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Looks good to me
Have tagged @jenhadfield-dfe for a review before this is merged
jenhadfield-dfe
approved these changes
Oct 18, 2024
|
This can be merged first thing on Monday morning :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/wo4ao4Nj/6765-fix-overlapping-headings-on-inspiration-navigation-cards?filter=member:spencerldixon
Context
Headings on inspiration navigation cards that wrap onto two lines are overlapping.
We need to fix the styling so that the words aren’t overlapping.
Changes proposed in this pull request
I find the
highlight-textmixin isn't working properly and causes multilines of text to overlap.highlight-textmixin to apply styles to a secondspantag that is set torelativeto create a new stacking context where the text sits on top of the previous span, used as the background.spanwherever we encounter overlapGuidance to review