Updated internship listings #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,23 +10,14 @@ promo_content: | |||
| - content/train-to-be-a-teacher/promos/eta-promo-internships | |||
| backlink: / | |||
| fullwidth: true | |||
| navigation: 20.30 | |||
| navigation: 20.25 | |||
There was a problem hiding this comment.
@sarahcrack @martyn-w I think the script needs updating slightly as this change isn't needed
Emma changed this nav order from 20.25 to 20.30 when she created the new placements page as part of #4213 so we need to keep it at 20.30
There was a problem hiding this comment.
(completely forgot about the internship script when approving Emma's PR!)
There was a problem hiding this comment.
hi @gemmadallmandfe sure no probs I'll go in and change that now :)
|
Review app deployed to https://get-into-teaching-app-review-4259.test.teacherservices.cloud |
|
gemmadallmandfe
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/S1WGwTYm/6685-upload-latest-internships-listings
Context
The internships team have some updated listing details that they would like to be uploaded.
Changes proposed in this pull request
Updated CSV file and ran rake task.
Guidance to review