Privacy notice link opening in new tab changes #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariosh-e
changed the title
mariosh-e
commented
Oct 9, 2024
changed to 'opens in new tab'
|
Review app deployed to https://get-into-teaching-app-review-4229.test.teacherservices.cloud |
|
jenhadfield-dfe
approved these changes
Oct 9, 2024
jenhadfield-dfe
approved these changes
Oct 9, 2024
martyn-w
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/z1slwQj4
Context
On the ‘Get Into Teaching’ page, there is a link that opens in a new tab, but which neither visually nor programmatically forewarns users that this will be the case.
Changes proposed in this pull request
Added
(opens in a new tab)to all privacy notice links - this is the only internal link that opens in a new tab across the site