Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Career changers inspirational section #4225

Merged
merged 12 commits into from
Oct 7, 2024

Conversation

emmaachesongray
Copy link
Contributor

Trello card

https://trello.com/c/LH3spdud/6610

Context

Changes proposed in this pull request

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code Style content Content changes Config labels Oct 2, 2024
@github-actions github-actions bot added the Review label Oct 2, 2024
@emmaachesongray
Copy link
Contributor Author

@jenhadfield-dfe could you help fix the issue with the inspo nav cards on the sub-category page as they are currently stacked on top of each other, rather than side by side?

Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments/changes @emmaachesongray

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @emmaachesongray - a few comments for you!

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a front end perspective - once you've resolved the styling change, happy for this to be merged

Copy link

github-actions bot commented Oct 7, 2024

Copy link

sonarcloud bot commented Oct 7, 2024

Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@emmaachesongray emmaachesongray merged commit 9618ccc into master Oct 7, 2024
26 checks passed
@emmaachesongray emmaachesongray deleted the Career-changers-inspirational-pages branch October 7, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config content Content changes Review ruby Pull requests that update Ruby code Style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants