-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Career changers inspirational section #4225
Conversation
@jenhadfield-dfe could you help fix the issue with the inspo nav cards on the sub-category page as they are currently stacked on top of each other, rather than side by side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few comments/changes @emmaachesongray
app/views/content/life-as-a-teacher/teaching-as-a-career/_what-teachers-have-to-say.html.erb
Outdated
Show resolved
Hide resolved
.../life-as-a-teacher/teaching-as-a-career/becoming-a-parent-sparked-my-interest-in-teaching.md
Outdated
Show resolved
Hide resolved
...her/teaching-as-a-career/becoming-a-parent-sparked-my-interest-in-teaching/_article.html.erb
Outdated
Show resolved
Hide resolved
.../life-as-a-teacher/teaching-as-a-career/making-a-career-change-to-teaching/_article.html.erb
Outdated
Show resolved
Hide resolved
…com/DFE-Digital/get-into-teaching-app into Career-changers-inspirational-pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @emmaachesongray - a few comments for you!
.../life-as-a-teacher/teaching-as-a-career/becoming-a-parent-sparked-my-interest-in-teaching.md
Outdated
Show resolved
Hide resolved
...her/teaching-as-a-career/becoming-a-parent-sparked-my-interest-in-teaching/_article.html.erb
Outdated
Show resolved
Hide resolved
...her/teaching-as-a-career/becoming-a-parent-sparked-my-interest-in-teaching/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/making-a-career-change-to-teaching.md
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/_what-teachers-have-to-say.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/making-a-career-change-to-teaching.md
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/making-a-career-change-to-teaching.md
Outdated
Show resolved
Hide resolved
.../life-as-a-teacher/teaching-as-a-career/making-a-career-change-to-teaching/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/_what-teachers-have-to-say.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from a front end perspective - once you've resolved the styling change, happy for this to be merged
Review app deployed to https://get-into-teaching-app-review-4225.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Trello card
https://trello.com/c/LH3spdud/6610
Context
Changes proposed in this pull request
Guidance to review