Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show icon funding widget mobile #4211

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

sarahcrack
Copy link
Collaborator

Trello card

https://trello.com/c/yc3LHedm/6628-show-icon-on-funding-widget-on-mobile

Context

Currently the money icon contained within the funding widget on the bursaries and scholarship page disappears when the screen shrinks to mobile size - the icon needs to stay on screen and not disappear, so that the component still stands out to users.

Changes proposed in this pull request

SimpleComponent (rendered within the funding widget) styling adapted to have desired effect.

Guidance to review

  • Please check the scholarships and bursaries page to make sure the funding widget/icon behaves as expected on different screen sizes.

Screenshot 2024-09-27 at 15 36 23
Screenshot 2024-09-27 at 15 33 37

  • The SimpleComponent in question is also utilised on the homepage (salaries banner) but the changes don't appear to have affected the banner due to some overriding CSS; an extra pair of eyes to check this would be appreciated (the money icon should still disappear on smaller screen sizes here).

Screenshot 2024-09-27 at 15 31 13
Screenshot 2024-09-27 at 15 35 21

@github-actions github-actions bot added ruby Pull requests that update Ruby code Style labels Sep 27, 2024
Copy link

Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gemmadallmandfe
Copy link
Contributor

Looks good to me - tested on mobile as well as in emulator, looking at both bursaries page (funding widget) and home page (salaries box)

However, @jenhadfield-dfe should review as the design expert before this is merged!

@jenhadfield-dfe
Copy link
Contributor

looks good to me!

@sarahcrack sarahcrack merged commit 3b70153 into master Oct 2, 2024
24 of 25 checks passed
@sarahcrack sarahcrack deleted the show-icon-funding-widget-mobile branch October 2, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review ruby Pull requests that update Ruby code Style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants