Links to subject and age group pages #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ruby
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
emmaachesongray
commented
Oct 1, 2024
app/views/content/steps-to-become-a-teacher/_step_4_find_a_teacher_training_course.html.erb
Outdated
Show resolved
Hide resolved
…cher_training_course.html.erb
| @@ -28,7 +28,7 @@ | |||
| </p> | |||
|
|
|||
| <p> | |||
| If you're interested in teaching certain subjects, you might be able to get a scholarship or bursary of up to <%= v :scholarships_generic_maxshortened %> tax-free. | |||
| If you're interested in <%= link_to("teaching certain subjects", page_path("life-as-a-teacher/explore-subjects")) %>, you might be able to get a scholarship or bursary of up to <%= v :scholarships_generic_maxshortened %> tax-free. | |||
There was a problem hiding this comment.
I'm not sure this is a good link to include - we will be building out the explore subjects section to include non-bursary subjects?
This is also a paid search/social landing page so is noindexed - so not so relevant for SEO. Plus we tried to have a principle of only one signposting link per section on these pages!
emmaachesongray
commented
Oct 2, 2024
app/views/content/landing/how-to-become-a-teacher/_content.html.erb
Outdated
Show resolved
Hide resolved
|
Review app deployed to https://get-into-teaching-app-review-4207.test.teacherservices.cloud |
gemmadallmandfe
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/njLTjUOf/6465
Context
Changes proposed in this pull request
Guidance to review