-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salary changes to paid langing pages #4205
Conversation
### Trello card https://trello.com/c/1hEfOnoc/6542-update-paid-advertising-landing-pages-to-mention-starting-salary ### Context The advertising team can’t promote the new £31k starting salary until after the consultation period - and their advertising schedules mean that they can’t start running ads with the new salary amount until the new year We've added the new £31k to three pages, agreed with the advertising team. ### Changes proposed in this pull request ### Guidance to review
@@ -2,7 +2,7 @@ | |||
<div class="col col-full-content"> | |||
<%= render Content::PurpleBoxComponent.new( | |||
heading: "Find out more about getting into teaching", | |||
text: "Explore how you can get into teaching primary or secondary and find top tips on making a successful application.", | |||
text: "Explore how you can get into teaching primary or secondary and find top tips on making a successful application. With a competitive starting salary of <%= v :salaries_starting_min %> (or higher in London), it pays to do what you love. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use <%= xxx %>
(line 5) brackets inside of <%= xxx %>
brackets (line 3). Try using the $form$
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating variables formatting
app/views/content/landing/how-to-become-a-teacher/_promo.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/landing/train-to-teach-if-you-have-a-degree/_promo.html.erb
Show resolved
Hide resolved
app/views/content/landing/how-to-become-a-teacher/_promo.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/landing/how-to-become-a-teacher/_promo.html.erb
Outdated
Show resolved
Hide resolved
@@ -7,7 +7,8 @@ | |||
checklist: [ | |||
"career progression ", | |||
"personal development", | |||
"opportunities to increase your pay" | |||
"opportunities to increase your pay", | |||
"a starting salary of $salaries_starting_min$ (or higher in London)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sarah-DfE I agree with your suggestion - these two bullets would probably make more sense the other way round, so starting salary is third (or maybe even first, if we are using a more linear order!) and increase pay is lower down that starting salary
Review app deployed to https://get-into-teaching-app-review-4205.test.teacherservices.cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Trello card
https://trello.com/c/1hEfOnoc/6542-update-paid-advertising-landing-pages-to-mention-starting-salary
Context
The advertising team can’t promote the new £31k starting salary until after the consultation period - and their advertising schedules mean that they can’t start running ads with the new salary amount until the new year
We've added the new £31k to three pages, agreed with the advertising team.
Changes proposed in this pull request
Guidance to review