Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER-864 Pin progress bar to bottom of card #969

Merged
merged 2 commits into from
Nov 16, 2023
Merged

ER-864 Pin progress bar to bottom of card #969

merged 2 commits into from
Nov 16, 2023

Conversation

peterdavidhamilton
Copy link
Contributor

@peterdavidhamilton peterdavidhamilton commented Nov 16, 2023 •
edited
Loading

@peterdavidhamilton peterdavidhamilton added this to the rc0.12.3 milestone Nov 16, 2023
@viezly viezly
Copy link

viezly bot commented Nov 16, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@instantrick instantrick added the review Review app deployed to Azure label Nov 16, 2023
@github-actions GitHub Actions
Copy link

https://eyrecovery-review-pr-969.azurewebsites.net

@instantrick
Copy link

instantrick commented Nov 16, 2023 •
edited
Loading

image

The new changes have pushed the text too close to the image.

You need to add some spacing to the bottom of image e.g.
.card-container img {
max-width: 100%;
margin-bottom: 5px;
}

@instantrick
Copy link

@peterdavidhamilton

image

The bar indicating the progress needs it's height reducing to 8px - I can't see where you are declaring it in the css but it is the line:
.bar-progress {
height: 8px;
top: 10px;
border-radius: 4px;
}

@github-actions github-actions bot added the frontend Changes to assets detected label Nov 16, 2023
@instantrick
Copy link

All looking good

@peterdavidhamilton peterdavidhamilton added this pull request to the merge queue Nov 16, 2023
instantrick
instantrick approved these changes Nov 16, 2023
View reviewed changes
Copy link

@instantrick instantrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted

Merged via the queue into main with commit c35368e Nov 16, 2023
4 checks passed
@peterdavidhamilton peterdavidhamilton deleted the ER-864-adjustment branch November 16, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@instantrick instantrick instantrick approved these changes

Assignees
No one assigned
Labels
frontend Changes to assets detected review Review app deployed to Azure
Projects
None yet
Milestone
v0.12.3
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdavidhamilton @instantrick