Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER-704: Azure App Gateway #793

Merged
merged 7 commits into from
Aug 29, 2023
Merged

ER-704: Azure App Gateway #793

merged 7 commits into from
Aug 29, 2023

Conversation

sunny-sidhu-and
Copy link
Contributor

  • Creation and storage of SSL Certificate
  • Creation of Custom Domain
  • Creation of App Gateway

Jira: https://dfedigital.atlassian.net/jira/software/projects/ER/boards/125?selectedIssue=ER-704

@sunny-sidhu-and sunny-sidhu-and temporarily deployed to test August 26, 2023 10:23 — with GitHub Actions Inactive
@viezly
Copy link

viezly bot commented Aug 26, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@sunny-sidhu-and sunny-sidhu-and changed the title ER: Azure App Gateway ER-704: Azure App Gateway Aug 26, 2023
@sunny-sidhu-and sunny-sidhu-and temporarily deployed to test August 26, 2023 10:43 — with GitHub Actions Inactive
@github-actions github-actions bot added terraform Changes to Terraform detected pipeline Github workflow changes labels Aug 26, 2023
@sunny-sidhu-and sunny-sidhu-and temporarily deployed to test August 26, 2023 10:47 — with GitHub Actions Inactive
@peterdavidhamilton
Copy link
Contributor

As best as I can tell nothing seems out of place. Two questions:

  • Are the skipped checkov tests just whilst it's being developed?
  • How do we test/confirm this once it is merged and used?

@sunny-sidhu-and
Copy link
Contributor Author

@peterdavidhamilton

As best as I can tell nothing seems out of place. Two questions:

  • Are the skipped checkov tests just whilst it's being developed?
  • How do we test/confirm this once it is merged and used?
  • The skipped tests provide recommendations that are not applicable to our use case. For instance, App Service doesn't support the RBAC access policy model for Key Vault.
  • I've already manually deployed and tested as it's a big change. https://staging.child-development-training.education.gov.uk is behind the new gateway and firewall. :)

peterdavidhamilton
peterdavidhamilton approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@peterdavidhamilton peterdavidhamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 thanks for the link. I didn't think we had the subdomain yet; nice one.

@peterdavidhamilton peterdavidhamilton added this to the next release milestone Aug 29, 2023
@sunny-sidhu-and sunny-sidhu-and added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit f857115 Aug 29, 2023
5 checks passed
@sunny-sidhu-and sunny-sidhu-and temporarily deployed to development August 29, 2023 14:42 — with GitHub Actions Inactive
@peterdavidhamilton peterdavidhamilton deleted the ER-azure-app-gateway branch October 17, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdavidhamilton peterdavidhamilton peterdavidhamilton approved these changes

@ebrett ebrett Awaiting requested review from ebrett

Assignees
No one assigned
Labels
pipeline Github workflow changes terraform Changes to Terraform detected
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sunny-sidhu-and @peterdavidhamilton