ER-764 Remove deprecated non-CMS files #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterdavidhamilton
commented
Aug 16, 2023
•
peterdavidhamilton
commented
- ER-764 Primary ticket
- ER-771 additional data
- ER-802 additional bug fix
- Retire unused libraries, content, environment variables, tests, and code
- Add missing specs, correct inaccurate specs and boost coverage over 90%
- Rename methods and objects to be semantic and consistent
- Refactor helpers and controllers simplifying logic
- Dry up training controllers moving common logic into a module
- Prune, consolidate and organise locales for fewer microcopy resources
- Update documentation, pipelines, docker and linting exemptions
- Replace remaining ActiveHash objects
- Namespace new models used in the registration journey
- Add migration and seeding task for CMS powered user setting options
- Add setting, role and authority data debugging panel
- Make verbose console output optional
- Clean up test factories and seed users
… code - Add missing specs, correct inaccurate specs and boost coverage over 90% - Rename methods and objects to be semantic and consistent - Refactor helpers and controllers simplifying logic - Dry up training controllers moving common logic into a module - Prune, consolidate and organise locales for fewer microcopy resources - Update documentation, pipelines, docker and linting exemptions - Replace remaining ActiveHash objects - Namespace new models used in the registration journey - Add migration and seeding task for CMS powered user setting options - Add setting, role and authority data debugging panel - Make verbose console output optional
peterdavidhamilton
temporarily deployed
to
test
GitHub Actions
Inactive
|
This pull request is split into 39 parts for easier review. Changed files are located in these folders:
|
peterdavidhamilton
had a problem deploying
to
development
GitHub Actions
Failure
peterdavidhamilton
temporarily deployed
to
content
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
development
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
content
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
test
GitHub Actions
Inactive
github-actions
bot
added
documentation
ebrett
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Nice to see all the deleted code - too much to really comment and I think we should get this in and start testing. I will need to make some changes to the responses table to resolve conflicts.
Might be helpful to put the methods in the concerns files in alphabetical order.
peterdavidhamilton
temporarily deployed
to
development
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
content
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
test
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
test
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
content
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
development
GitHub Actions
Inactive
They were meant to grouped by how they are used (which is often also by type) in order of appearance. I'll fix that 👍🏼 |
peterdavidhamilton
had a problem deploying
to
production
GitHub Actions
Failure
peterdavidhamilton
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.