Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update returning users data dates #749

Merged
merged 18 commits into from
Aug 22, 2023
Merged

Update returning users data dates #749

merged 18 commits into from
Aug 22, 2023

Conversation

jack-coggin
Copy link
Contributor

@jack-coggin jack-coggin commented Jul 28, 2023 •
edited
Loading

  • Update the dates for which returning users are selected for the dashboard data model
  • Also update dashboard models to select registered users rather than all users where appropriate

@jack-coggin jack-coggin temporarily deployed to test July 28, 2023 14:59 — with GitHub Actions Inactive
@viezly
Copy link

viezly bot commented Jul 28, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@jack-coggin jack-coggin temporarily deployed to test July 28, 2023 15:11 — with GitHub Actions Inactive
@jack-coggin jack-coggin temporarily deployed to test July 31, 2023 13:18 — with GitHub Actions Inactive
@jack-coggin jack-coggin temporarily deployed to test August 2, 2023 11:08 — with GitHub Actions Inactive
@jack-coggin jack-coggin temporarily deployed to test August 2, 2023 11:09 — with GitHub Actions Inactive
@jack-coggin jack-coggin temporarily deployed to test August 2, 2023 11:12 — with GitHub Actions Inactive
peterdavidhamilton
peterdavidhamilton suggested changes Aug 8, 2023
View reviewed changes
app/models/data/returning_users.rb Outdated Show resolved Hide resolved
app/models/data/returning_users.rb Outdated Show resolved Hide resolved
app/models/data/module_overview.rb Outdated Show resolved Hide resolved
app/models/data/returning_users.rb Outdated Show resolved Hide resolved
app/models/data/returning_users.rb Outdated Show resolved Hide resolved
@peterdavidhamilton peterdavidhamilton added this to the Next Release milestone Aug 8, 2023
@jack-coggin jack-coggin temporarily deployed to test August 14, 2023 15:41 — with GitHub Actions Inactive
peterdavidhamilton
peterdavidhamilton reviewed Aug 15, 2023
View reviewed changes
db/schema.rb Outdated Show resolved Hide resolved
@jack-coggin jack-coggin temporarily deployed to test August 17, 2023 13:48 — with GitHub Actions Inactive
@jack-coggin jack-coggin temporarily deployed to test August 18, 2023 08:48 — with GitHub Actions Inactive
peterdavidhamilton
peterdavidhamilton approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@peterdavidhamilton peterdavidhamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jack-coggin jack-coggin added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit d1912ad Aug 22, 2023
4 checks passed
@jack-coggin jack-coggin temporarily deployed to development August 22, 2023 08:57 — with GitHub Actions Inactive
@peterdavidhamilton peterdavidhamilton deleted the update-returning-users-data branch October 17, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdavidhamilton peterdavidhamilton peterdavidhamilton approved these changes

@ebrett ebrett Awaiting requested review from ebrett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jack-coggin @peterdavidhamilton