Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ER-572] [ER-757] Proof of concept to show if splitting up the coercion helps #725

Merged
merged 3 commits into from
Jul 19, 2023
Merged

[ER-572] [ER-757] Proof of concept to show if splitting up the coercion helps #725

merged 3 commits into from
Jul 19, 2023

Conversation

ebrett
Copy link
Contributor

@ebrett ebrett commented Jul 19, 2023 •
edited by jira bot
Loading

ER-572 Stats metric - just a proof of concept for user file processing
ER-757 unrelated, but a quick fix for the my-modules page

@viezly
Copy link

viezly bot commented Jul 19, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@ebrett ebrett added the deployed Review app deployed for testing label Jul 19, 2023
@ebrett ebrett temporarily deployed to content July 19, 2023 11:50 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to test July 19, 2023 11:55 — with GitHub Actions Inactive
@github-actions
Copy link

https://ey-recovery-pr-725.london.cloudapps.digital

@ebrett ebrett temporarily deployed to content July 19, 2023 12:50 — with GitHub Actions Inactive
@ebrett ebrett marked this pull request as ready for review July 19, 2023 13:07
jack-coggin
jack-coggin approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jack-coggin jack-coggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ebrett ebrett added this pull request to the merge queue Jul 19, 2023
Merged via the queue into main with commit c19ac8b Jul 19, 2023
4 checks passed
@ebrett ebrett temporarily deployed to production July 19, 2023 16:30 — with GitHub Actions Inactive
@ebrett ebrett deleted the ER-572-user-csv branch July 19, 2023 16:30
@ebrett ebrett added this to the rc0.8.3 milestone Jul 19, 2023
@ebrett ebrett changed the title Proof of concept to show if splitting up the coercion helps [ER-572] [ER-757] Proof of concept to show if splitting up the coercion helps Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-coggin jack-coggin jack-coggin approved these changes

@peterdavidhamilton peterdavidhamilton Awaiting requested review from peterdavidhamilton

Assignees
No one assigned
Labels
deployed Review app deployed for testing
Projects
None yet
Milestone
rc0.8.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ebrett @jack-coggin