Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER-793 feedback forms #1102

Merged
merged 108 commits into from
Jul 5, 2024
Merged

ER-793 feedback forms #1102

merged 108 commits into from
Jul 5, 2024

Conversation

peterdavidhamilton
Copy link
Contributor

@peterdavidhamilton peterdavidhamilton commented Feb 27, 2024 •
edited
Loading

ER-793

For reviewing authenticated users, visit this link to sign in:
https://eyrecovery-review-pr-1102.azurewebsites.net/users/review

  • guest association for site-wide forms by unauthenticated visitors
  • feedback specific services/decorators using inheritance
  • abstracted CMS test feedback questions in all 3 valid modules
  • update debugging panels
  • update content validity checks
  • ensure feedback journey is tracked using events
  • add anonymous feedback metrics to data export
  • switch review app to master to QA functionality using different content
  • redact user free text answers on account closure
  • encrypt free text user data
  • data export of anonymised responses

New cookies:

course_feedback

Deleted resources (6):

thankyou.heading
thankyou.body
my_account.email_preferences
my_account.training_emails.true
my_account.training_emails.false
notice.email_changed

Changed resources (1):

next_page.finish

New resources (24):

links.home
links.my_modules
links.feedback.update
links.feedback.skip
previous_page.previous
next_page.give_feedback
summary_intro.heading
activerecord.errors.models.response.attributes.answers.invalid
feedback.cta
feedback.intro
feedback.complete
feedback.research
feedback.reasons
my_account.email_preferences.heading
my_account.email_preferences.label
my_account.email_preferences.link_text
my_account.email_preferences.preference.true
my_account.email_preferences.preference.false
my_account.research_preferences.heading
my_account.research_preferences.label
my_account.research_preferences.link_text
my_account.research_preferences.preference.true
my_account.research_preferences.preference.false

@peterdavidhamilton peterdavidhamilton added the review Review app deployed to Azure label Feb 27, 2024
@github-actions GitHub Actions
Copy link

https://eyrecovery-review-pr-1102.azurewebsites.net

@peterdavidhamilton peterdavidhamilton mentioned this pull request Feb 28, 2024
Merged
@peterdavidhamilton
Defend against fat controller anti-pattern
67e04d3 
The inbound site-wide feedback form attempt fails to reuse existing code
and this will help the refactor once it is merged in.

The Pagination module functionality relies on the "parent" having "pages".
Course.config now functions like a Training::Module.
@github-actions github-actions bot added the content Course and page content changes label Feb 28, 2024
@martikat @jack-coggin
@peterdavidhamilton @dependabot
End of module feedback form and main feedback form (#1089)
bc32ff0 
* wip

* wip: Update to add opinion intro and opinion

* wip: Update to include other text field

* wip: Update for new question response type

* wip: add text area feedback question type

* wip: Update for end of module feedback journey and feedback intro buttons

* wip: Update end of module feedback journey

* wip: Update to hide Additional feedback in module overview

* wip: Progress bar update to match designs

* wip: Update to ensure error handling is shown when no option is selected

* wip: Update to include optional show of hint text for feedback questions

* wip: update to ensure feedback questions can be used across modules

* wip: create feedback forms controller

* ER-892 Assessment Results Banner styling update (#1011)

* Update margin bottom for assessment result banner

* Update to ensure only assessment banner styling is updated

* Update margin bottom for assessment results banner following PR comment

* Update to where styling is applied for assessment results banner

* GovOne authentication integration changes (#1020)

* WIP

* tweak logout path logic

* Existing session logic

* Opt in WCAG logic

* add check for session id token in logout link

* QA debug

* Avoid duplicate hits on about page

* Sanity check

* Fix memory issue for QA locally

and in pipeline?

* Trigger full WCAG check on demand if already deployed and includes changes

* Factory and count

* Test feature in pipeline

* Integrate GovOne to replace existing sessions and skip deprecated specs

* Update docs and fix specs

* Increase coverage

* Fix pa11y and plan to retire old devise functionality

* Tidy

* Delete old GPaaS debugging var

---------

Co-authored-by: jack.coggin <[email protected]>

* Bump rubocop-govuk from 4.12.0 to 4.13.0 (#1025)

* Bump rubocop-govuk from 4.12.0 to 4.13.0

Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) from 4.12.0 to 4.13.0.
- [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md)
- [Commits](alphagov/rubocop-govuk@v4.12.0...v4.13.0)

---
updated-dependencies:
- dependency-name: rubocop-govuk
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Conform to new style guide

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter David Hamilton <[email protected]>

* ER-872 GovOne Banner (#1038)

* Add banner regarding change to Gov One authentication

* Update link to external content

* Quick CMS resource debugger (#1040)

* Quick CMS resource debugger

* Improve coverage

* LINTING!!!

* Correct case

* ER-899 Local Authority User active user update (#1041)

* Update local authority user to not count closed accounts

* Update closed trait to inherit from registered

* Remove validation skipping for GOV.UK One Login user creation (#1031)

* remove validation skipping for one login user creation

* rubocop

* move random password logic to own method

* update t&c logic for one login enabled

* rubocop

* skip existing sign up spec if gov one login enabled

* add one login enabled to check to specs

* skip one login user creation in specs if gov one login not enabled

* tweak user spec

* update sessions controller spec

* update user spec

* add spec for terms and conditions form

* add spec for role type form

* update user spec

* Exceed coverage threshold

* fix locales typo

* Improve course engagement test coverage and fix misnamed method

---------

Co-authored-by: Peter David Hamilton <[email protected]>

* update gov.uk one login integration credentials (#1037)

* update gov one integration credentials

* Fix domain running in production locally

---------

Co-authored-by: Peter David Hamilton <[email protected]>

* Always recreate container for background workers (#1045)

* CMS powered site-wide config (#1044)

* PoC for top-level config object defined in CMS

* Course configuration

* Spec and CMS migration

* Fix invalid JS migration

* Correct double escape in validation regexp

* Force confirmation when destroying containers. (#1052)

Use --yes.

* Bump puma from 6.4.0 to 6.4.2 (#1039)

      Bumps [puma](https://github.com/puma/puma) from 6.4.0 to 6.4.2.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](puma/puma@v6.4.0...v6.4.2)

---
updated-dependencies:
- dependency-name: puma
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects from 1.15.3 to 1.15.4 (#1043)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Er 832 Early years experience (#1048)

* remove validation skipping for one login user creation

* rubocop

* move random password logic to own method

* update t&c logic for one login enabled

* rubocop

* skip existing sign up spec if gov one login enabled

* add one login enabled to check to specs

* skip one login user creation in specs if gov one login not enabled

* tweak user spec

* update sessions controller spec

* update user spec

* add spec for terms and conditions form

* add spec for role type form

* update user spec

* Exceed coverage threshold

* fix locales typo

* add early years experience registration step

* update back links for registration steps

* add early years experience to account page

* add new registration journey events and update early years experience registration form

* update yard annotation in ey experience form

* update seeds snippets spec locales count

* add tracking to all registration controllers

* fix key typo

* fix event tracking in registration controllers

---------

Co-authored-by: Peter David Hamilton <[email protected]>

* Update Local Authority User to count using specific criteria and add new counts to user overview (#1053)

* ER-893 Certificate design (#1051)

- Adjust the design of the certificate page to include a thumbnail sample.
- Adjust the typography of the certificate PDF with conditional styling.
- Install additional fonts for use by Puppeteer and Chromium (further work required).

* ER-898 CMS model evolution (#1018)

* wip

* Make assessment threshold value a dev concern and validate new field

* Refactor module #card_title to #heading with coverage

* Update effected spec

* Update release docs and QA password

* Post catch-up renaming

* Migration correct names

* Migration correct names more

* Delete stubbed field used during transition

* wip: navigate between main feedback form questions

* wip

* wip: add answer validation

* wip: add validation

* rubocop

* add support for nil user responses

* wip: allow user to update previous answers

* add introduction and thank you pages

* add additional text input for further details

* wip

* wip: Update to add opinion intro and opinion

* wip: Update to include other text field

* wip: Update for new question response type

* wip: add text area feedback question type

* wip: Update for end of module feedback journey and feedback intro buttons

* wip: Update end of module feedback journey

* wip: Update to hide Additional feedback in module overview

* wip: Progress bar update to match designs

* wip: Update to ensure error handling is shown when no option is selected

* wip: Update to include optional show of hint text for feedback questions

* wip: update to ensure feedback questions can be used across modules

* wip: Update for responses table and saving text input questions

* wip: Update one-off question logic and page count logic in module

* wip: Copy across opinion radio button

* update migrations

* create guest struct

* Update logic for link helper and update specs

* Update specs and text input logic update in response model

* Ensure CMS webhooks continue to work even whilst in maintenance mode (#1103)

* fix course spec

* Update ci workflow with correct feature flags and update specs

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: jack.coggin <[email protected]>
Co-authored-by: Peter Hamilton <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jack-coggin <[email protected]>
@github-actions github-actions bot added frontend Changes to assets detected pipeline Github workflow changes labels Feb 29, 2024
peterdavidhamilton
peterdavidhamilton commented Mar 1, 2024
View reviewed changes
app/controllers/feedback_controller.rb Outdated Show resolved Hide resolved
app/controllers/feedback_controller.rb Outdated Show resolved Hide resolved
app/decorators/next_page_decorator.rb Outdated Show resolved Hide resolved
app/helpers/link_helper.rb Outdated Show resolved Hide resolved
app/helpers/link_helper.rb Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
app/models/course.rb Show resolved Hide resolved
spec/controllers/feedback_controller_spec.rb Show resolved Hide resolved
spec/decorators/pagination_decorator_spec.rb Outdated Show resolved Hide resolved
spec/decorators/pagination_decorator_spec.rb Outdated Show resolved Hide resolved
@peterdavidhamilton peterdavidhamilton merged commit 5590a98 into main Jul 5, 2024
4 checks passed
@peterdavidhamilton peterdavidhamilton removed the blocked Currently blocked label Jul 5, 2024
@peterdavidhamilton peterdavidhamilton deleted the ER-793-feedback-forms branch July 5, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-coggin jack-coggin jack-coggin left review comments

@martikat martikat martikat approved these changes

@instantrick instantrick instantrick approved these changes

Assignees

@peterdavidhamilton peterdavidhamilton

Labels
a11y WCAG AA content Course and page content changes documentation Improvements or additions to documentation frontend Changes to assets detected pass Acceptance criteria met pipeline Github workflow changes review Review app deployed to Azure
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@peterdavidhamilton @instantrick @martikat @jack-coggin