Refactor (#1176)

DFE-Digital · May 22, 2024 · 6396667 · 6396667
1 parent 5cfcf95
commit 6396667
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/app/forms/form_builder.rb b/app/forms/form_builder.rb
@@ -64,11 +64,11 @@ def select_trainee_authority
   end
 
   def select_trainee_experience
-    govuk_collection_select :early_years_experience,
-                            Trainee::Experience.all, :name, :name,
-                            label: { text: I18n.t('register_early_years_experience.label'), class: 'govuk-visually-hidden' },
-                            aria: { label: 'registration early years experience' },
-                            form_group: { classes: %w[data-hj-suppress] }
+    govuk_collection_radio_buttons :early_years_experience,
+                                   Trainee::Experience.all, :id, :name,
+                                   legend: { text: I18n.t('register_early_years_experience.label'), class: 'govuk-visually-hidden govuk-!-padding-top-9' },
+                                   aria: { label: 'registration early years experience' },
+                                   form_group: { classes: %w[data-hj-suppress] }
   end
 
   def opt_in_out(field)

diff --git a/app/forms/registration/early_years_experiences_form.rb b/app/forms/registration/early_years_experiences_form.rb
@@ -4,11 +4,6 @@ class EarlyYearsExperiencesForm < BaseForm
 
     validates :early_years_experience, presence: true
 
-    # @return [Array<Trainee::Experience>]
-    def early_years_experiences
-      Trainee::Experience.all
-    end
-
     # @return [Boolean]
     def save
       return false unless valid?

diff --git a/app/views/registration/early_years_experiences/edit.html.slim b/app/views/registration/early_years_experiences/edit.html.slim
@@ -1,7 +1,7 @@
 = render 'user/debug'
 
 - content_for :page_title do
-  = html_title t(:heading, scope: :early_years_experience)
+  = html_title t('register_early_years_experience.heading')
 
 = govuk_back_link href: edit_registration_role_type_path
 
@@ -13,7 +13,7 @@
       = f.govuk_fieldset legend: { text: t('register_early_years_experience.heading')  }, aria: { required: true } do
         .data-hj-suppress
           div class='govuk-!-margin-top-4'
-            = f.govuk_collection_radio_buttons :early_years_experience, form.early_years_experiences, :id, :name, legend: { text: t('early_years_experienc.heading'), class: 'govuk-visually-hidden govuk-!-padding-top-9' }, form_group: { classes: %w[data-hj-suppress] }
+            = f.select_trainee_experience
 
       = f.govuk_submit t('links.continue')