Skip to content

Commit

Permalink
remove missed comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jack-coggin committed Sep 5, 2023
1 parent f5d53e3 commit 5fa18c6
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 9 deletions.
3 changes: 1 addition & 2 deletions config/initializers/que.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
Que::Scheduler.configure do |config|
config.schedule = {
DashboardJob: { cron: Rails.application.config.dashboard_update_interval },
# TODO: change this interval before merging
CompleteRegistrationMailJob: { cron: '*/5 * * * *' },
CompleteRegistrationMailJob: { cron: Rails.application.config.mail_job_interval },
StartTrainingMailJob: { cron: Rails.application.config.mail_job_interval },
ContinueTrainingMailJob: { cron: Rails.application.config.mail_job_interval },
}
Expand Down
1 change: 0 additions & 1 deletion spec/jobs/complete_registration_mail_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,5 @@
]
end

# 1 user receives the :complete_registration email template
it_behaves_like 'an email prompt'
end
3 changes: 1 addition & 2 deletions spec/jobs/continue_training_mail_job_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'rails_helper'

RSpec.describe ContinueTrainingMailJob do
include_context 'with progress' # why if this is event powered
include_context 'with progress'

let(:template) { :continue_training }

Expand Down Expand Up @@ -40,6 +40,5 @@
travel_back
end

# 1 user receives the :continue_training email template
it_behaves_like 'an email prompt', nil, Training::Module.by_name(:alpha)
end
3 changes: 0 additions & 3 deletions spec/jobs/new_module_mail_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
create_list :user, 2, :registered, confirmed_at: 4.weeks.ago
end

# module_release == a publication

before do
create(:release, id: 1)
create(:module_release, release_id: 1, module_position: 1, name: 'alpha')
Expand All @@ -24,6 +22,5 @@
complete_module(bravo, 1.minute)
end

# 1 user receives the :new_module email template informing them of the new module: charlie
it_behaves_like 'an email prompt', 2, Training::Module.by_name(:charlie)
end
1 change: 0 additions & 1 deletion spec/jobs/start_training_mail_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,5 @@
]
end

# 1 user receives the :start_training email template
it_behaves_like 'an email prompt'
end

0 comments on commit 5fa18c6

Please sign in to comment.