Fix duplicate ids and empty elements

DFE-Digital · Aug 22, 2023 · 30a49ed · 30a49ed
1 parent 38179b6
commit 30a49ed
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 4 deletions.
diff --git a/app/views/close_accounts/confirm.html.slim b/app/views/close_accounts/confirm.html.slim
@@ -1,3 +1,6 @@
+- content_for :page_title do
+  = html_title t('close_account.confirm.heading')
+
 .govuk-grid-row
   .govuk-grid-column-two-thirds-from-desktop
     = govuk_back_link(href: edit_reason_user_close_account_path)

diff --git a/app/views/close_accounts/edit_reason.html.slim b/app/views/close_accounts/edit_reason.html.slim
@@ -1,3 +1,6 @@
+- content_for :page_title do
+  = html_title 'Tell us why you want to close your account'
+
 .govuk-grid-row
   .govuk-grid-column-two-thirds-from-desktop
     = govuk_back_link(href: user_path)

diff --git a/app/views/close_accounts/new.html.slim b/app/views/close_accounts/new.html.slim
@@ -1,3 +1,6 @@
+- content_for :page_title do
+  = html_title 'For security, enter your password.'
+
 .govuk-grid-row
   .govuk-grid-column-two-thirds-from-desktop
     = govuk_back_link(href: user_path)
@@ -8,7 +11,7 @@
         = f.govuk_password_field :current_password,
           autofocus: true,
           aria: { required: true },
-          label: { text: 'For security, enter your password.'},
+          label: { text: 'For security, enter your password.' },
           hint: { text: 'Your password' } do 
           p= govuk_details(summary_text: 'Problems with your password?') do
             p.govuk-heading-s= 'I have forgotten my password'

diff --git a/app/views/errors/internal_server_error.html.slim b/app/views/errors/internal_server_error.html.slim
@@ -1,3 +1,6 @@
+- content_for :page_title do
+  = html_title 'Sorry, there is a problem with the service'
+
 .govuk-grid-row
   .govuk-grid-column-two-thirds
     h1.govuk-heading-xl

diff --git a/app/views/errors/not_found.html.slim b/app/views/errors/not_found.html.slim
@@ -1,3 +1,6 @@
+- content_for :page_title do
+  = html_title 'Page not found'
+
 .govuk-grid-row
   .govuk-grid-column-two-thirds
     h1.govuk-heading-xl

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -578,8 +578,7 @@ en:
     summary: |
       %{description}
 
-      ## What you'll learn
-      {: .govuk-heading-m}
+      **What you'll learn**
 
       This module covers:
 

diff --git a/config/sitemap.rb b/config/sitemap.rb
@@ -48,7 +48,7 @@
 
   # errors
   add '/404'
-  add '/422'
+  # add '/422'
   add '/500'
 
   add users_timeout_path