fix: Career stage should have been pluralised

Merge pull request #254 from DFE-Digital/fix-career-stages
DFE-Digital · Sep 6, 2023 · c8eed1f · c8eed1f
2 parents 08212db + 2d649b5
commit c8eed1f
Show file tree

Hide file tree

Showing 16 changed files with 17 additions and 17 deletions.
diff --git a/Childrens-Social-Care-CPD/Views/Shared/_ErrorLayout.cshtml b/Childrens-Social-Care-CPD/Views/Shared/_ErrorLayout.cshtml
@@ -55,8 +55,8 @@
                         </a>
                     </li>
                     <li class="dfe-header__navigation-item" id="mmi-career">
-                        <a class="dfe-header__navigation-link" href="/career-stage">
-                            Career stage
+                        <a class="dfe-header__navigation-link" href="/career-stages">
+                            Career stages
                             <svg class="dfe-icon dfe-icon__chevron-right" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" aria-hidden="true" width="34" height="34">
                                 <path d="M15.5 12a1 1 0 0 1-.29.71l-5 5a1 1 0 0 1-1.42-1.42l4.3-4.29-4.3-4.29a1 1 0 0 1 1.42-1.42l5 5a1 1 0 0 1 .29.71z"></path>
                             </svg>

diff --git a/Childrens-Social-Care-CPD/Views/Shared/_Header.cshtml b/Childrens-Social-Care-CPD/Views/Shared/_Header.cshtml
@@ -50,7 +50,7 @@
             <ul class="dfe-header__navigation-list">
                 @{
                     RenderMenuItem("home", "Home", "home", category == "Home");
-                    RenderMenuItem("career", "Career stage", "career-stage", category == "Career stage");
+                    RenderMenuItem("career", "Career stages", "career-stages", category == "Career information");
                     RenderMenuItem("developmentProgrammes", "Development programmes", "development-programmes", category == "Development programmes");
                     RenderMenuItem("exploreRoles", "Explore roles", "explore-roles", category == "Explore roles");
                 }

diff --git a/browser-tests/content-regression-tests/tests/career-stages/asye.spec.ts b/browser-tests/content-regression-tests/tests/career-stages/asye.spec.ts
@@ -12,7 +12,7 @@ test.describe('Assessed and supported year in employment (ASYE)', () => {
 
     test('User journey via Career menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Practitioners', exact: true }).click()
         await page.getByRole('link', { name: 'Assessed and supported year in employment (ASYE)', exact: true }).click()
 

diff --git a/...r-tests/content-regression-tests/tests/career-stages/develop-social-work-practice.spec.ts b/...r-tests/content-regression-tests/tests/career-stages/develop-social-work-practice.spec.ts
@@ -14,7 +14,7 @@ test.describe('Experienced Practitioners', () => {
 
     test('User journey via menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Practitioners', exact: true }).click()
         await page.getByRole('link', { name: 'Develop your social work practice', exact: true }).click()
 

diff --git a/browser-tests/content-regression-tests/tests/career-stages/experienced-practitioners.spec.ts b/browser-tests/content-regression-tests/tests/career-stages/experienced-practitioners.spec.ts
@@ -13,7 +13,7 @@ test.describe('Experienced Practitioners', () => {
 
     test('User journey via menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Experienced practitioners', exact: true }).click()
 
         await expect(page.locator('h1', { hasText: /^Experienced practitioners$/ })).toBeVisible()

diff --git a/browser-tests/content-regression-tests/tests/career-stages/leaders.spec.ts b/browser-tests/content-regression-tests/tests/career-stages/leaders.spec.ts
@@ -12,7 +12,7 @@ test.describe('Leaders', () => {
 
     test('User journey via menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Leaders', exact: true }).click()
 
         await expect(page.locator('h1', { hasText: /^Leaders$/ })).toBeVisible()

diff --git a/browser-tests/content-regression-tests/tests/career-stages/managers.spec.ts b/browser-tests/content-regression-tests/tests/career-stages/managers.spec.ts
@@ -12,7 +12,7 @@ test.describe('Managers', () => {
 
     test('User journey via menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Managers', exact: true }).click()
 
         await expect(page.locator('h1', { hasText: /^Managers$/ })).toBeVisible()

diff --git a/...tests/content-regression-tests/tests/career-stages/pathway-1-practice-supervisors.spec.ts b/...tests/content-regression-tests/tests/career-stages/pathway-1-practice-supervisors.spec.ts
@@ -13,7 +13,7 @@ test.describe('Pathway 1: practice supervisors', () => {
 
     test('User journey via Career menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Experienced practitioners', exact: true }).click()
         await page.getByRole('link', { name: 'Pathway 1: practice supervisors', exact: true }).click()
 

diff --git a/browser-tests/content-regression-tests/tests/career-stages/pathway-2-middle-managers.spec.ts b/browser-tests/content-regression-tests/tests/career-stages/pathway-2-middle-managers.spec.ts
@@ -23,7 +23,7 @@ test.describe('Pathway 2: middle managers', () => {
 
     test('User journey via Career menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Experienced practitioners', exact: true }).click()
         await page.getByRole('link', { name: 'Pathway 2: middle managers', exact: true }).click()
 

diff --git a/...ser-tests/content-regression-tests/tests/career-stages/pathway-3-heads-of-service.spec.ts b/...ser-tests/content-regression-tests/tests/career-stages/pathway-3-heads-of-service.spec.ts
@@ -23,7 +23,7 @@ test.describe('Pathway 3: heads of service', () => {
 
     test('User journey via Career menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Managers', exact: true }).click()
         await page.getByRole('link', { name: 'Pathway 3: heads of service', exact: true }).click()
 

diff --git a/...ser-tests/content-regression-tests/tests/career-stages/pathway-4-practice-leaders.spec.ts b/...ser-tests/content-regression-tests/tests/career-stages/pathway-4-practice-leaders.spec.ts
@@ -23,7 +23,7 @@ test.describe('Pathway 4: practice leaders', () => {
 
     test('User journey via Career menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Leaders', exact: true }).click()
         await page.getByRole('link', { name: 'Pathway 4: practice leaders', exact: true }).click()
 

diff --git a/browser-tests/content-regression-tests/tests/career-stages/practitioners.spec.ts b/browser-tests/content-regression-tests/tests/career-stages/practitioners.spec.ts
@@ -12,7 +12,7 @@ test.describe('Practitioners', () => {
 
     test('User journey via menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Practitioners', exact: true }).click()
 
         await expect(page.locator('h1', { hasText: /^Practitioners$/ })).toBeVisible()

diff --git a/browser-tests/content-regression-tests/tests/career-stages/senior-managers.spec.ts b/browser-tests/content-regression-tests/tests/career-stages/senior-managers.spec.ts
@@ -12,7 +12,7 @@ test.describe('Senior managers', () => {
 
     test('User journey via menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Senior managers', exact: true }).click()
 
         await expect(page.locator('h1', { hasText: /^Senior managers$/ })).toBeVisible()

diff --git a/...ts/content-regression-tests/tests/career-stages/upon-aspirant-directors-programme.spec.ts b/...ts/content-regression-tests/tests/career-stages/upon-aspirant-directors-programme.spec.ts
@@ -13,7 +13,7 @@ test.describe('Upon: aspirant directors programme', () => {
 
     test('User journey via menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Leaders', exact: true }).click()
         await page.getByRole('link', { name: 'Upon: aspirant directors programme', exact: true }).click()
 

diff --git a/...r-tests/content-regression-tests/tests/career-stages/upon-new-directors-programme.spec.ts b/...r-tests/content-regression-tests/tests/career-stages/upon-new-directors-programme.spec.ts
@@ -13,7 +13,7 @@ test.describe('Upon: new directors programme', () => {
 
     test('User journey via menu @journey', async ({ page }) => {
         await page.goto('/')
-        await page.getByLabel('Menu').getByRole('link', { name: 'Career stage', exact: true }).click()
+        await page.getByLabel('Menu').getByRole('link', { name: 'Career stages', exact: true }).click()
         await page.getByRole('link', { name: 'Leaders', exact: true }).click()
         await page.getByRole('link', { name: 'Upon: new directors programme', exact: true }).click()
 

diff --git a/browser-tests/content-regression-tests/tests/header.spec.ts b/browser-tests/content-regression-tests/tests/header.spec.ts
@@ -8,7 +8,7 @@ test.describe('Header', () => {
 
     const links = [
         ['Home', '/home'],
-        ['Career stage', '/career-stage'],
+        ['Career stages', '/career-stages'],
         ['Development programmes', '/development-programmes'],
         ['Explore roles', '/explore-roles'],
     ]