fix: Sonar suggestions

Merge pull request #274 from DFE-Digital/fix/sonar-fixes
DFE-Digital · Sep 20, 2023 · b6f4a81 · b6f4a81
2 parents 261b7a6 + 29e7e70
commit b6f4a81
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 23 deletions.
diff --git a/Childrens-Social-Care-CPD/Views/Content/Index.cshtml b/Childrens-Social-Care-CPD/Views/Content/Index.cshtml
@@ -15,7 +15,7 @@
 
 @section Hero {
     @{
-        var heroBanner = Model.Items?.FirstOrDefault(x => x.GetType() == typeof(HeroBanner));
+        var heroBanner = Model.Items?.Find(x => x.GetType() == typeof(HeroBanner));
         if (heroBanner != null)
         {
             <partial name="_HeroBanner" model="heroBanner" />

diff --git a/Childrens-Social-Care-CPD/Views/Cookie/Cookies.cshtml b/Childrens-Social-Care-CPD/Views/Cookie/Cookies.cshtml
@@ -9,10 +9,6 @@
 @inject ICookieHelper _cookieHelper
 @inject IRenderer<ContentLink> _contentLinkRenderer
 
-@{
-    var prefsHaveBeenSet = _cookieHelper.GetRequestAnalyticsCookieState(Context) != AnalyticsConsentState.NotSet;
-}
-
 @if (ViewBag.ContextModel.PreferenceSet)
 {
     <div class="govuk-grid-row">

diff --git a/Childrens-Social-Care-CPD/Views/Shared/_ContentSeparator.cshtml b/Childrens-Social-Care-CPD/Views/Shared/_ContentSeparator.cshtml
@@ -6,16 +6,16 @@
     switch (Model.Type)
     {
         case "Extra Large" : 
-            <hr class="govuk-section-break govuk-section-break--xl govuk-section-break--visible">;
+            <hr class="govuk-section-break govuk-section-break--xl govuk-section-break--visible">
             break;
         case "Large" : 
-            <hr class="govuk-section-break govuk-section-break--l govuk-section-break--visible">;
+            <hr class="govuk-section-break govuk-section-break--l govuk-section-break--visible">
             break;
         case "Medium":
             <hr class="govuk-section-break govuk-section-break--m govuk-section-break--visible">
-            ; break;
+            break;
         case "Small":
             <hr class="govuk-section-break govuk-section-break--s govuk-section-break--visible">
-            ; break;
+            break;
     }
 }
diff --git a/Childrens-Social-Care-CPD/Views/Shared/_RichText.cshtml b/Childrens-Social-Care-CPD/Views/Shared/_RichText.cshtml
@@ -26,22 +26,21 @@
     {
         switch (node)
         {
-            case HorizontalRuler hr: @_horizontalRulerRenderer.Render(hr); break;
-            case Paragraph paragraph: @_paragraphRenderer.Render(paragraph); break;
-            case List list: @_listRenderer.Render(list); break;
-            case Heading1 heading1: @_heading1Renderer.Render(heading1); break;
-            case Heading2 heading2: @_heading2Renderer.Render(heading2); break;
-            case Heading3 heading3: @_heading3Renderer.Render(heading3); break;
-            case Heading4 heading4: @_heading4Renderer.Render(heading4); break;
-            case Heading5 heading5: @_heading5Renderer.Render(heading5); break;
-            case Heading6 heading6: @_heading6Renderer.Render(heading6); break;
-            case Table table: @_tableRenderer.Render(table); break;
-            case Quote quote: @_quoteRenderer.Render(quote)
-                ; break;
+            case HorizontalRuler hr: @_horizontalRulerRenderer.Render(hr) break;
+            case Paragraph paragraph: @_paragraphRenderer.Render(paragraph) break;
+            case List list: @_listRenderer.Render(list) break;
+            case Heading1 heading1: @_heading1Renderer.Render(heading1) break;
+            case Heading2 heading2: @_heading2Renderer.Render(heading2) break;
+            case Heading3 heading3: @_heading3Renderer.Render(heading3) break;
+            case Heading4 heading4: @_heading4Renderer.Render(heading4) break;
+            case Heading5 heading5: @_heading5Renderer.Render(heading5) break;
+            case Heading6 heading6: @_heading6Renderer.Render(heading6) break;
+            case Table table: @_tableRenderer.Render(table) break;
+            case Quote quote: @_quoteRenderer.Render(quote) break;
             case EntryStructure entryStructure: {
                     switch (entryStructure.Data.Target)
                     {
-                        case RoleList roleList: @_roleListRenderer.Render(roleList); break;
+                        case RoleList roleList: @_roleListRenderer.Render(roleList) break;
                     }
                     break;
             }

diff --git a/Childrens-Social-Care-CPD/Views/Shared/_RichTextBlock.cshtml b/Childrens-Social-Care-CPD/Views/Shared/_RichTextBlock.cshtml
@@ -15,7 +15,7 @@
             var tagBuilder = new TagBuilder($"h{level}");
             tagBuilder.InnerHtml.Append(Model.Title);
 
-            @tagBuilder;
+            @tagBuilder
         }
     }
 }